GitHub User: carlmanaster
I think the test_should_have_zero_for_weight_when_not_shipping test is very weak. weight will return zero simply because there are no line items, with no weights. If you had line_item.build_delivery_method(:shipping => true) instead, the result would still be zero.
Do we need to set updating_password back to false to avoid future updates from invoking the validation? If not, why not?